Set experimental dynamo config for compile tests #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, a lot of tests fail when applying torch.compile to PEFT models. One of the main reasons is that attribute checks (self.foo) on nn.Modules are not correctly considered. This PR sets an experimental flag that should fix this. However, this is not public PyTorch API (yet) and incurs a performance penalty. Still, it's interesting to see how this affects our tests. More context: pytorch/pytorch#124717 (comment)
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
younesbelkada
approved these changes
Apr 30, 2024
|
Yeah, let's first see how this affects the number of failing tests. Also, I have no idea how big the performance hit is, if it's slower than without compile there is little incentive to use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, a lot of tests fail when applying torch.compile to PEFT models. One of the main reasons is that attribute checks (e.g.
if self.foo) onnn.Modules are not correctly considered.This PR sets an experimental flag that should fix this. However, this is not public PyTorch API (yet) and incurs a performance penalty. Still, it's interesting to see how this affects our tests.
More context:
pytorch/pytorch#124717 (comment)