CI Make torch compile tests run on GPU #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many of these tests require a GPU to run, so use custom runners. Code was mostly copied from existing workflows, I hope that this works.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
younesbelkada
approved these changes
May 29, 2024
Comment on lines
23
to
26
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| docker-image-name: ["huggingface/peft-gpu-bnb-latest:latest"] |
There was a problem hiding this comment.
nit: we don't really need matrix here since we're testing it only on "huggingface/peft-gpu-bnb-latest:latest"
Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
|
@younesbelkada Thanks for the review. I kept the test matrix with a single entry to make it easier to extend in the future but as is, it's indeed not needed, so it's removed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of these tests require a GPU to run, so use custom runners.
Code was mostly copied from existing workflows, I hope that this works.