Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add trufflehog secrets detection #1841

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Conversation

McPatate
Copy link
Member

What does this PR do?

Adding a GH action to scan for leaked secrets on each commit.

@McPatate McPatate requested a review from younesbelkada June 10, 2024 07:50
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@BenjaminBossan
Copy link
Member

BenjaminBossan commented Jun 10, 2024

Just a question, for accelerate there is an extra permissions section:

https://github.com/huggingface/accelerate/pull/2836/files

Would it be good to have it here too?

@McPatate
Copy link
Member Author

@BenjaminBossan I've been removing them given they were set incorrectly. It was a mishap on my end, sorry!

Not sure what the default permissions are for the organization though, I'd have to check.

@McPatate
Copy link
Member Author

(I'll merge for now, will revisit if the defaults are too open)

@McPatate McPatate merged commit 683db0f into main Jun 10, 2024
15 checks passed
@McPatate McPatate deleted the feat/add_trufflehog_ci branch June 10, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants