FIX: Adalora ranknum loaded on wrong device #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locally, multiple AdaLoRA-related tests are failing. We did not catch this in the nightly run because the tests were missing the necessary pytest marker. The issue is related to the change in huggingface#1742, which made it possible to load different adapters on different devices. Although that PR itself was sound, the issue is that for AdaLoRA, one of its parameters, ranknum, was not listed in the other_param_names and was thus not moved to the correct device. This oversight is now fixed and the GPU tests are now passing locally for me. This PR also adds the missing pytest marker to the test class that was missing it, so that these errors should be caught by our nightly CI in the future.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
younesbelkada
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally, multiple AdaLoRA-related tests are failing. We did not catch this in the nightly run because the tests were missing the necessary pytest marker.
The issue is related to the change in #1742, which made it possible to load different adapters on different devices. Although that PR itself was sound, the problem is that for AdaLoRA, one of its parameters,
ranknum, was not listed in theother_param_namesand was thus not moved to the correct device. This oversight is now fixed and the GPU tests are now passing locally for me.Note that this bug only occurred in the tests when loading a 2nd AdaLoRA adapter. At first I was confused because I thought that this is not supported (there is a check for that), but actually it's supported as long as the additional adapters are not trainable, so the check is fine.
This PR also adds the missing pytest marker to the test class that was missing it, so that these errors should be caught by our nightly CI in the future.