TST: Potentially Skip 8bit bnb regression test if compute capability is too low #1998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 8bit bnb LoRA regression test results are dependent on the underlying compute capability. The logits are slightly different depending on the version (up to 0.5 abs diff). Therefore, we now check the compute capability for this test and skip it if it's too low. This check may require updating if the hardware of the CI worker is updated. Note that I have already invalidated the old regression artifacts and created a new one.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
After internal discussion, we think this is the most practical solution for the time being.
Titus-von-Koeller
approved these changes
Aug 16, 2024
BenjaminBossan
deleted the
tst-require-compute-capability-for-bnb-8bit-regression-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 8bit bnb LoRA regression test results are dependent on the underlying compute capability. The logits are slightly different depending on the version (up to 0.5 abs diff). Therefore, we now check the compute capability for this test and skip it if it's too low. This check may require updating if the hardware of the CI worker is updated.
Note that I have already invalidated the old regression artifacts and created a new one.