[CI] Add ci tests
#203
Merged
[CI] Add ci tests
#203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younesbelkada
commented
Mar 23, 2023
pacman100
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
Thank you @younesbelkada for all the work on adding CI support 🤗.
Left a comment
tests/test_peft_model.py
Outdated
| **config_kwargs, | ||
| ) | ||
| model = get_peft_model(model, config) | ||
| model = prepare_model_for_training(model) |
There was a problem hiding this comment.
This has been removed, right?
There was a problem hiding this comment.
ah yes I forgot to push something, will push now
There was a problem hiding this comment.
Added it in 4ff8380
I think we need an utility function to perform:
if hasattr(model, "enable_input_require_grads"):
model.enable_input_require_grads()
else:
def make_inputs_require_grad(module, input, output):
output.requires_grad_(True)
model.get_input_embeddings().register_forward_hook(make_inputs_require_grad)Happy to do it in a follow up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a CI tests workflow for PEFT
cc @pacman100