-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix arguments for PiSSA preprocess #2053
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Thanks for identifying these errors and providing a fix. Could you please run |
@keakon I think your latest commit made it worse :) Your first commit was almost good, I think it was just missing one more empty line between imports and code, there should always be two empty lines. |
I tried running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this fix, LGTM.
Pinging @fxmeng who added PiSSA, just in case. If there is no response, I'll merge at the end of the week. |
Thanks again @keakon. We didn't hear back by the end of the week, so I'll just go ahead and merge this now. |
Fix bug in parsing command line arguments in the PiSSA preprocess.py script from the PiSSA example.
Fix two bugs:
ArgumentParser
does not have ahelp
argument.--output_dir
argument is missing.