Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix arguments for PiSSA preprocess #2053

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Conversation

keakon
Copy link
Contributor

@keakon keakon commented Sep 7, 2024

Fix two bugs:

  1. The ArgumentParser does not have a help argument.
  2. The --output_dir argument is missing.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@BenjaminBossan
Copy link
Member

Thanks for identifying these errors and providing a fix. Could you please run make style on your changes?

@BenjaminBossan
Copy link
Member

@keakon I think your latest commit made it worse :) Your first commit was almost good, I think it was just missing one more empty line between imports and code, there should always be two empty lines.

@keakon
Copy link
Contributor Author

keakon commented Sep 10, 2024

@keakon I think your latest commit made it worse :) Your first commit was almost good, I think it was just missing one more empty line between imports and code, there should always be two empty lines.

I tried running make style, and it seems I missed a blank line the first time.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this fix, LGTM.

@BenjaminBossan
Copy link
Member

Pinging @fxmeng who added PiSSA, just in case. If there is no response, I'll merge at the end of the week.

@BenjaminBossan
Copy link
Member

Thanks again @keakon. We didn't hear back by the end of the week, so I'll just go ahead and merge this now.

@BenjaminBossan BenjaminBossan merged commit 4a8dedb into huggingface:main Sep 13, 2024
14 checks passed
BenjaminBossan pushed a commit to BenjaminBossan/peft that referenced this pull request Sep 18, 2024
Fix bug in parsing command line arguments in the PiSSA preprocess.py script from
the PiSSA example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants