Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST Speed up vision model tests #2058

Merged

Conversation

BenjaminBossan
Copy link
Member

The HRA vision model test is extremely slow on CI (> 600 sec, ~50% of total time). This change speeds up the test by using a smaller ResNet model to run the tests.

It's still not clear why HRA was so slow specifically -- LoRA is 40x faster -- but that can be fixed separately.

HRA author has been notified 5 days ago but no response so far.

The HRA vision model test is extremely slow on CI (> 600 sec, 50% of
total time). This change speeds up the test by using a smaller ResNet
model to run the tests.

It's still not clear why HRA was so slow specifically -- LoRA is 40x
faster -- but that can be fixed separately.
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@BenjaminBossan
Copy link
Member Author

So just an example, for Python-3.10-ubuntu-latest, test time went down from 18 min to 10 min!

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one!

@BenjaminBossan BenjaminBossan merged commit 54be5a3 into huggingface:main Sep 10, 2024
14 checks passed
@BenjaminBossan BenjaminBossan deleted the tst-speed-up-vision-tests branch September 10, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants