Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scaling option to loftq #2073

Closed
wants to merge 1 commit into from
Closed

Add scaling option to loftq #2073

wants to merge 1 commit into from

Conversation

sparsh2
Copy link
Contributor

@sparsh2 sparsh2 commented Sep 17, 2024

Add missing scaling option to loftq like dora

@BenjaminBossan
Copy link
Member

Thanks for the PR. For others, the context is issue #1982.

Honestly, I'm unsure if adding the scale here is correct or not. @fxmeng it would be great if you could take a look.

@sparsh2
Copy link
Contributor Author

sparsh2 commented Oct 6, 2024

Let me close this PR till we have a clarity on the scaling in #1982

@sparsh2 sparsh2 closed this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sparsh2 @BenjaminBossan