Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Remove version pin of diffusers #2162

Conversation

BenjaminBossan
Copy link
Member

The diffusers<0.21.0 pin was added way back in #936 and then we forget to ever remove it.

This is now causing trouble, as the old diffusers version still uses cached_download, which was removed from huggingface_hub:

ImportError: cannot import name 'cached_download' from 'huggingface_hub'

The pin was added way back in huggingface#936 and then we forget to ever remove it.

This is now causing trouble, as the old diffusers version still uses
cached_download, which was removed from huggingface_hub:

> ImportError: cannot import name 'cached_download' from 'huggingface_hub'
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@BenjaminBossan BenjaminBossan merged commit 57a452a into huggingface:main Oct 18, 2024
14 checks passed
@BenjaminBossan BenjaminBossan deleted the fix-remove-diffusers-version-pin branch October 18, 2024 10:31
sirluk pushed a commit to sirluk/peft that referenced this pull request Oct 19, 2024
The pin was added way back in huggingface#936 and then we forget to ever remove it.

This is now causing trouble, as the old diffusers version still uses
cached_download, which was removed from huggingface_hub:

> ImportError: cannot import name 'cached_download' from 'huggingface_hub'
yaswanth19 pushed a commit to yaswanth19/peft that referenced this pull request Oct 20, 2024
The pin was added way back in huggingface#936 and then we forget to ever remove it.

This is now causing trouble, as the old diffusers version still uses
cached_download, which was removed from huggingface_hub:

> ImportError: cannot import name 'cached_download' from 'huggingface_hub'
yaswanth19 pushed a commit to yaswanth19/peft that referenced this pull request Oct 20, 2024
The pin was added way back in huggingface#936 and then we forget to ever remove it.

This is now causing trouble, as the old diffusers version still uses
cached_download, which was removed from huggingface_hub:

> ImportError: cannot import name 'cached_download' from 'huggingface_hub'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants