Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] EVA meta device check bug + add multi-gpu functionality #2218

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

sirluk
Copy link
Contributor

@sirluk sirluk commented Nov 17, 2024

This PR contains

  • an important bugfix for a faulty device check in eva.py.
  • torch all_gather operations for all SVD Hooks to be able to leverage a higher batch size for EVA in multi-gpu setups.
  • An example in the docs for using EVA with multiple GPUs

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for these improvemens to EVA. I tried the multi-GPU script and it worked.

@BenjaminBossan BenjaminBossan merged commit 3a8afbe into huggingface:main Nov 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants