FIX Correctly set device of input data in bnb test #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a failing CI bitsandbytes CI test. The input data was on CPU but the model is on GPU, resulting in an error. Note that this mismatch was not an issue previously because accelerate added an AlignDevicesHook that took care of this. With the latest accelerate, this is no longer the case, whereas the hook is present for v1.1.1. In any case, it's better that we set the device of the data explicitly, so I think this is a safe change. But it would be good to know what happened that caused this change.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Titus-von-Koeller
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a failing CI bitsandbytes CI tests here and here.
The input data was on CPU but the model is on GPU, resulting in an error. Note that this mismatch was not an issue previously because accelerate added an
AlignDevicesHookthat took care of this. With the latest accelerate, this is no longer the case, whereas the hook is present for v1.1.1.In any case, it's better that we set the device of the data explicitly, so I think this is a safe change. But it would be good to know what happened that caused this change.
Note: CI won't catch these errors, as the tests require GPU. However, I reproduced and confirmed locally.