TST: Skip test on multi-GPU as DataParallel fails #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test fails in multi-GPU setting because transformers.Trainer switches to DataParallel. As this is not a commonly used parallelization strategy, it should be okay to just skip this.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
githubnemo
approved these changes
Nov 25, 2024
BenjaminBossan
deleted the
tst-skip-test-that-fails-with-dataparallel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test fails in multi-GPU setting because
transformers.Trainerswitches toDataParallel. As this is not a commonly used parallelization strategy, it should be okay to just skip this. The test will still be run on single GPU and CPU.https://github.com/huggingface/peft/actions/runs/12002085686/job/33453519249#step:6:45046
Unfortunately, once this test fails, all subsequent tests also fail with
so it's important to fix this test fast, as it may mask other failures on multi-GPU.