[core] Fix offload issue
#248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
Hello @younesbelkada, thank you for fixing the issue with offloading. I believe #188 PR does address it partly. It would be great to have them incorporate the additional changes or add them as co-author for the PR |
|
Thanks for the heads up! That PR went out of my radar, I added them as a co-author of this PR |
pacman100
approved these changes
Apr 1, 2023
There was a problem hiding this comment.
Thank you @cosimoiaia and @younesbelkada for fixing this issue, LGTM! 😄
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #136
Fixes #225
Inside
PeftModel, the kwargs relative to cpu/disk offloading were missingcc @pacman100