Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] LoRA for token classification #302

Merged
merged 4 commits into from
Apr 18, 2023

Conversation

stevhliu
Copy link
Member

@stevhliu stevhliu commented Apr 13, 2023

Moves the LoRA for token classification notebook into the docs and adapts it for a less-complicated example instead of training LayoutLM on annotated forms.

  • complete the training section with either a native PyTorch loop or Trainer

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 13, 2023

The documentation is not available anymore as the PR was closed or merged.

@stevhliu stevhliu marked this pull request as ready for review April 13, 2023 23:38
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @stevhliu for simplifying the token classification example to an interesting bionlp dataset!

Left few comments

docs/source/task_guides/token-classification-lora.mdx Outdated Show resolved Hide resolved
docs/source/task_guides/token-classification-lora.mdx Outdated Show resolved Hide resolved
docs/source/task_guides/token-classification-lora.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@MKhalusova MKhalusova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice guide! I left a few nits here and there.

docs/source/task_guides/token-classification-lora.mdx Outdated Show resolved Hide resolved
docs/source/task_guides/token-classification-lora.mdx Outdated Show resolved Hide resolved
docs/source/task_guides/token-classification-lora.mdx Outdated Show resolved Hide resolved
docs/source/task_guides/token-classification-lora.mdx Outdated Show resolved Hide resolved
docs/source/task_guides/token-classification-lora.mdx Outdated Show resolved Hide resolved
docs/source/task_guides/token-classification-lora.mdx Outdated Show resolved Hide resolved
docs/source/task_guides/token-classification-lora.mdx Outdated Show resolved Hide resolved
docs/source/task_guides/token-classification-lora.mdx Outdated Show resolved Hide resolved
@stevhliu stevhliu force-pushed the lora-token-classification branch from f5b9ff4 to 903eb31 Compare April 14, 2023 21:08
@stevhliu stevhliu requested a review from pacman100 April 14, 2023 21:17
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @stevhliu for iterating, LGTM! 🚀
I really like the example and the dataset used.

@stevhliu stevhliu merged commit 34027fe into huggingface:main Apr 18, 2023
@stevhliu stevhliu deleted the lora-token-classification branch April 18, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants