Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Task guide with Dreambooth LoRA example #330

Merged
merged 8 commits into from
Apr 20, 2023

Conversation

MKhalusova
Copy link
Contributor

This PR adds a task guide based on this example

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 18, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and concise! ✨

I would also add an example of a generated image for even greater impact, and also add a link to the conceptual LoRA guide once it's merged.

--output_dir=$OUTPUT_DIR \
--train_text_encoder \
--with_prior_preservation --prior_loss_weight=1.0 \
--instance_prompt="a photo of sks dog" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe briefly explain what sks is and what it does. I'd also mention that we're training on a dataset of dog images (or link to it) so users have a better idea of the initial images and where this prompt comes from.

Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MKhalusova for adding the task guide with the lora dreambooth example 🤗! This is a really cool usecase.

Left a comment

MKhalusova and others added 4 commits April 19, 2023 08:56
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Sourab Mangrulkar <13534540+pacman100@users.noreply.github.com>
…booth

# Conflicts:
#	docs/source/task_guides/dreambooth_lora.mdx
@MKhalusova MKhalusova requested a review from pacman100 April 19, 2023 18:46
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The multi inference adapter example is really cool! Super cool prompt of dog in supermarket isle 😁. Thank you @MKhalusova for adding the details on the helper functions leveraging PEFT multi adapter features. LGTM! 🤗

@MKhalusova MKhalusova merged commit f703cb2 into huggingface:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants