fix lora modules_to_save issue #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
younesbelkada
approved these changes
Apr 20, 2023
| @@ -68,7 +68,7 @@ | |||
| class ClassInstantier(OrderedDict): | |||
| def __getitem__(self, key, *args, **kwargs): | |||
| # check if any of the kwargs is inside the config class kwargs | |||
| if any([kwarg in self[key][1] for kwarg in kwargs]): | |||
| if any(kwarg in self[key][1] for kwarg in kwargs): | |||
There was a problem hiding this comment.
Curious why this is needed?
There was a problem hiding this comment.
ruff raises quality issue.
There was a problem hiding this comment.
Ok I see, I think it's ok to merge it as it is,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
modules_to_savearen't working when using LoRA. This PR fixes it. modules_to_save: "ValueError: Attempting to unscale FP16 gradients" #341 (comment)