Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Supported models tables #364

Merged
merged 5 commits into from
Apr 26, 2023

Conversation

MKhalusova
Copy link
Contributor

As a suggestion, this PR moves the tables listing supported models to the index page since the supported methods are also listed there.

In addition, this PR adds links to the quicktour and conceptual guides to help beginners navigate the docs.

@MKhalusova MKhalusova requested a review from stevhliu April 24, 2023 15:13
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 24, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I think placing it on the index immediately gives users an idea of whether their use case is supported or not 👍

docs/source/index.mdx Show resolved Hide resolved
docs/source/index.mdx Outdated Show resolved Hide resolved
docs/source/index.mdx Outdated Show resolved Hide resolved
docs/source/index.mdx Outdated Show resolved Hide resolved
MKhalusova and others added 2 commits April 24, 2023 12:24
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@MKhalusova MKhalusova requested a review from pacman100 April 24, 2023 16:37
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MKhalusova for updating the doc page with the supported models tables, LGTM! 🚀

Left a suggestion based on recently merged PRs


Supported methods include:
If you are new to PEFT, get started by reading the [Quicktour](quicktour) guide and conceptual guides for [LoRA](/conceptual_guides/lora) and [Prompting](/conceptual_guides/prompting) methods.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

docs/source/index.mdx Outdated Show resolved Hide resolved
Co-authored-by: Sourab Mangrulkar <13534540+pacman100@users.noreply.github.com>
@MKhalusova MKhalusova merged commit e8f66b8 into huggingface:main Apr 26, 2023
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants