Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use try and finally in disable_adapter() to catch exceptions #368

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Use try and finally in disable_adapter() to catch exceptions #368

merged 1 commit into from
Apr 26, 2023

Conversation

mukobi
Copy link
Contributor

@mukobi mukobi commented Apr 26, 2023

Fixes #367

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 26, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

pacman100
pacman100 approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mukobi for fixing this, LGTM!🤗

@pacman100 pacman100 merged commit 2c2bbb4 into huggingface:main Apr 26, 2023
@mukobi mukobi deleted the patch-1 branch April 26, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacman100 pacman100 pacman100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PeftModel.disable_adapter() context manager doesn't release on exception
3 participants
@mukobi @HuggingFaceDocBuilderDev @pacman100