Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Removes warnings about unknown pytest marker #715

Merged

Conversation

BenjaminBossan
Copy link
Member

This is a low prio PR but it solves an annoyance.

Right now, when running tests, the output is spammed by messages like:

PytestUnknownMarkWarning: Unknown pytest.mark.multi_gpu_tests - is this a typo? ...

This makes it more difficult to see the actually relevant information. This PR fixes this by registering the two pytest markers we use, thus removing the warnings.

This is a low prio PR but it solves an annoyance.

Right now, when running tests, the output is spammed by messages like:

> PytestUnknownMarkWarning: Unknown pytest.mark.multi_gpu_tests - is
this a typo? ...

This makes it more difficult to see the actually relevant information.
This PR fixes this by registering the two pytest markers we use, thus
removing the warnings.
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 17, 2023

The documentation is not available anymore as the PR was closed or merged.

@BenjaminBossan BenjaminBossan requested a review from pacman100 July 17, 2023 09:57
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @BenjaminBossan for this, very helpful!

@pacman100 pacman100 merged commit a1953ba into huggingface:main Jul 17, 2023
@BenjaminBossan BenjaminBossan deleted the fix-pytest-unknown-mark-warning branch July 17, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants