Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subfolder issue #721

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Fix subfolder issue #721

merged 2 commits into from
Jul 19, 2023

Conversation

younesbelkada
Copy link
Contributor

@younesbelkada younesbelkada commented Jul 18, 2023 •
edited
Loading

Fixes #718

in the PR #712 , I forgot to properly deal with subfolder argument, in fact they will appear in hf_hub_download_kwargs as subfolder is in the signature of hf_hub_download method

cc @pacman100 @BenjaminBossan

Added also a nice CI test

@younesbelkada younesbelkada requested a review from pacman100 July 18, 2023 07:26
@younesbelkada younesbelkada mentioned this pull request Jul 18, 2023
Closed
4 tasks
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 18, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

BenjaminBossan
BenjaminBossan approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice adding tests. It could be parameterized instead of looping, but not a big issue.

pacman100
pacman100 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @younesbelkada for fixing this, LGTM!

@pacman100 pacman100 merged commit 1b8b17d into huggingface:main Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

@pacman100 pacman100 pacman100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug when pass subfolder parameter in peftmodel.load_adapter method!
4 participants
@younesbelkada @HuggingFaceDocBuilderDev @BenjaminBossan @pacman100