ENH: Warn when disabling adapters and bias != 'none' #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed internally. For LoRA, given that bias='all' or bias='none', when doing inference with a model in the disable_adapter context, the output will not be identical to the output of the base model. This may be surprising to users. Therefore, a warning is given. Furthermore, the docstring has been extended to reflect this fact.
pacman100
approved these changes
Jul 21, 2023
|
The documentation is not available anymore as the PR was closed or merged. |
BenjaminBossan
deleted the
warning-when-disabling-adapters-with-modified-biases
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed internally.
For LoRA, given that
bias='all'orbias='none', when doing inference with a model in thedisable_adapter()context, the output will not be identical to the output of the base model. This may be surprising to users. Therefore, a warning is given. Furthermore, the docstring has been extended to reflect this fact.