-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Ascend NPU adapter loading #772
Conversation
@BenjaminBossan @younesbelkada could you please review this PR? thanks🤗 |
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx.
Just a more general question: Do we have any kind of test to show that NPU (or XPU for that matter) actually work?
@BenjaminBossan Thanks for your reply. I verified the effectiveness of this PR at LLaMA-Efficient-Tuning, which integrates peft. If necessary, I could include additional test cases for third-party accelerators like NPU/XPU in a separate PR. This would be done under the assumption that these accelerators have cuda-like APIs within the PyTorch ecosystem. |
Very nice, thanks for the pointer.
For me it was just important to ensure that someone has actually tested it. I don't know if we need these additional tests. On the one hand, it would be nice to have those to catch regressions, on the other hand they're probably not easy to integrate. I'll leave it up to the other maintainers to decide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @statelesshz for adding NPU support, LGTM! 🚀
What does this PR do?