Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Update docstring of PeftModel.from_pretrained #799

Merged
merged 1 commit into from
Aug 8, 2023
Merged

DOC: Update docstring of PeftModel.from_pretrained #799

merged 1 commit into from
Aug 8, 2023

Conversation

BenjaminBossan
Copy link
Member

@BenjaminBossan
Update docstring of PeftModel.from_pretrained
14b06c8 
1. Addresses
huggingface#430 (comment)
2. Reword docstring to not be LoRA-specific
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 7, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

stevhliu
stevhliu approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for generalizing to PEFT models and not just LoraModel! 😄

pacman100
pacman100 approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @BenjaminBossan for updating the docstrings!

@BenjaminBossan BenjaminBossan merged commit ba90047 into huggingface:main Aug 8, 2023
@BenjaminBossan BenjaminBossan deleted the DOC-update-from-pretrained-docstring branch August 8, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevhliu stevhliu stevhliu approved these changes

@pacman100 pacman100 pacman100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenjaminBossan @HuggingFaceDocBuilderDev @pacman100 @stevhliu