Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in ia3.py #844

Merged
merged 6 commits into from
Aug 25, 2023
Merged

Fix typos in ia3.py #844

merged 6 commits into from
Aug 25, 2023

Conversation

AstrisCantCode
Copy link
Contributor

I noticed they led to weird formatting on the HF documentation here: https://huggingface.co/docs/peft/main/en/package_reference/tuners#peft.IA3Config

@BenjaminBossan
Copy link
Member

Could you please add back in the line breaks? We have a limit of 119 characters.

@AstrisCantCode
Copy link
Contributor Author

should be fixed now.

@BenjaminBossan
Copy link
Member

Thanks, almost there. After the line breaks, the text should be indented (see the diff).

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@AstrisCantCode
Copy link
Contributor Author

really really works now, just had to RTFM a little

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the docstring.

@BenjaminBossan BenjaminBossan merged commit 8c17d55 into huggingface:main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants