Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce memory allocations #350

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Reduce memory allocations #350

merged 1 commit into from
Aug 30, 2023

Conversation

cospectrum
Copy link
Contributor

No description provided.

@Narsil
Copy link
Collaborator

Narsil commented Aug 30, 2023

Thanks for the PR !

Have you noticed any performance change ? That I could try to reproduce.

The code looks to be better anyway.

@Narsil Narsil merged commit 5af8cba into huggingface:main Aug 30, 2023
9 of 10 checks passed
@cospectrum
Copy link
Contributor Author

I definitely noticed an improvement in deserialization performance with cargo bench, for me it is about 100 microseconds (4%). The serialization bench does not show stable changes for me. I didn't check python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cospectrum @Narsil