Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs, untested] Attempt to fix links to source #420

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

pcuenca
Copy link
Member

@pcuenca pcuenca commented Jan 4, 2024

What does this PR do?

The functions in this page link to something like:
https://github.com/huggingface/safetensors/blob/main/src/safetensors/torch.py#L284 (which does not exist), however
https://github.com/huggingface/safetensors/blob/main/bindings/python/py_src/safetensors/torch.py#L284 does.

Looking at https://github.com/huggingface/doc-builder/blob/bc09a535b7ed1ccd1b57b59ccc0584a286fc3397/.github/workflows/build_main_documentation.yml#L159C38-L159C38 I see version_tag_suffix being used and accepted here.

I tried to test locally but --version_tag_suffix was not accepted, so I may still be missing something.

cc @mishig25

@pcuenca
Copy link
Member Author

pcuenca commented Jan 5, 2024

cc @Narsil too, in case you know how to test

@Narsil
Copy link
Collaborator

Narsil commented Jan 8, 2024

Thanks for this

@Narsil Narsil merged commit be6443d into huggingface:main Jan 8, 2024
3 of 10 checks passed
pcuenca added a commit to pcuenca/safetensors that referenced this pull request Jan 8, 2024
Followup to huggingface#420. Sorry.

We're almost there, examine the first `<source>` link in https://huggingface.co/docs/safetensors/api/torch to verify.
Narsil pushed a commit that referenced this pull request Jan 11, 2024
Followup to #420. Sorry.

We're almost there, examine the first `<source>` link in https://huggingface.co/docs/safetensors/api/torch to verify.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants