Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Use hfoptions for metadata #424

Merged
merged 2 commits into from
Jan 8, 2024
Merged

[docs] Use hfoptions for metadata #424

merged 2 commits into from
Jan 8, 2024

Conversation

mishig25
Copy link
Collaborator

@mishig25 mishig25 commented Jan 8, 2024

Based on this comment, bringing back the example on how to use http range requests to get metadata. Also, using hfoptions syntax for better UI/UX

you can test the page here: https://moon-ci-docs.huggingface.co/docs/safetensors/pr_424/en/metadata_parsing#usage

Screen.Recording.2024-01-08.at.2.12.39.PM.mov

@mishig25 mishig25 marked this pull request as ready for review January 8, 2024 13:14
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it @mishig25! Nice use case for hfoptions.
Not sure about naming http the one where we show a python snippet to parse using http requests but I don't have a better one to suggest so keeping it should be good 👍

@mishig25
Copy link
Collaborator Author

mishig25 commented Jan 8, 2024

Not sure about naming http the one where we show a python snippet to parse using http requests but I don't have a better one to suggest so keeping it should be good 👍

Indeed. That is the question. Maybe others can chime in

Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nice, thanks for adding this back 🙏

I think http (or raw but it's weird) works

@mishig25 mishig25 merged commit a7aa8d2 into main Jan 8, 2024
5 of 11 checks passed
@mishig25 mishig25 deleted the use_hf_options_metadata branch January 8, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants