Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs yml file enable install_libgl flag #202

Merged
merged 6 commits into from
Sep 20, 2022
Merged

docs yml file enable install_libgl flag #202

merged 6 commits into from
Sep 20, 2022

Conversation

mishig25
Copy link

@mishig25 mishig25 commented Sep 14, 2022

@natolambert doc-build action was failing because doc-builder image didn't have libGL, which is a pyvista dependency

ImportError: libGL.so.1: cannot open shared object file: No such file or directory

Therefore, I've added libgl to the image huggingface/doc-builder#294

Docs are building (you cah check at: https://moon-ci-docs.huggingface.co/docs/simenv/pr_202/) & everything is working except:
"Add doc comment" step , which is failing because it is a private repo.
@LysandreJik could you solve the issue as you have solved for api-inference here?

image

@mishig25 mishig25 changed the title [wip: fixing docs] docs yml file enable install_libgl flag Sep 14, 2022
@natolambert
Copy link
Contributor

natolambert commented Sep 14, 2022

Thanks so much, this would've taken me a while :).
For what it is worth, we will be making it public in a couple weeks, so we could also just wait if that final step is a lot of work.

Base automatically changed from docs to main September 19, 2022 16:37
@HuggingFaceDocBuilder
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@natolambert
Copy link
Contributor

Merging this @mishig25, we made the library public 🤗.

@natolambert natolambert merged commit cffa3c9 into main Sep 20, 2022
@natolambert natolambert deleted the mishig25-patch-1 branch September 20, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants