Seed NetworkMonitor state from currentPath to eliminate offline race at startup
#259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
mattt
force-pushed
the
mattt/fix-network-monitor-race
branch
from
091d6c8 to
78d3173
Compare
| Task { | ||
| await self.state.update(path: path) | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Noticed that startMonitoring gets called twice using the singleton method NetworkMonitor.shared.startMonitoring() if one doesnt yet exist. May want to also add a check for monitor.pathUpdateHandler == nil before setting it here in case the first update goes to a handler that was already replaced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #229
@pcuenca observed that tests were failing locally because
shouldUseOfflineModewas occasionally evaluatingisConnectedto befalse. This new behavior occurred after switching to Swift Testing, in #229. That PR didn't change anything about offline mode, but it did increase test parallelism, which I suspect surfaced a race condition in the network monitor.This PR updates the network monitor to seed the offline / online state immediately from
NWPathMonitor.currentPathafter callingstartMonitoring. This should fix intermittent offline-mode activation that's observed running tests locally.