feat: prefill chunking #2600
Open
feat: prefill chunking #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierDehaene
force-pushed
the
feat/prefix_chunking
branch
from
0c87a35
to
bdbc652
Compare
OlivierDehaene
force-pushed
the
feat/prefix_chunking
branch
from
70fe6ce
to
1b43d2d
Compare
OlivierDehaene
force-pushed
the
feat/prefix_chunking
branch
from
ea9384b
to
f923a3f
Compare
Narsil
reviewed
Oct 10, 2024
| @@ -531,7 +546,7 @@ mod tests { | |||
| request: ValidGenerateRequest { | |||
| inputs: vec![], | |||
| input_ids: Some(Arc::new(vec![])), | |||
| input_length: 0, | |||
| input_length: 1, | |||
There was a problem hiding this comment.
Really ? Isn't this supposed to be 0
Are you changing it for other reasons ?
There was a problem hiding this comment.
I don't know why it was 0. 0 is not a possible value in the router as it is considered invalid.
| @@ -784,7 +799,7 @@ mod tests { | |||
|
|
|||
| #[tokio::test] | |||
| async fn test_queue_next_batch_dropped_receiver() { | |||
| let queue = Queue::new(false, 1, false, None, 0, 16); | |||
| let queue = Queue::new(false, 1, false, None, 0, 16, false); | |||
There was a problem hiding this comment.
Should we add a few tests with chunking ?
| cache_length <= prompt_length | ||
| ), f"Prefix {cache_length} vs input {prompt_length}" | ||
| if cache_length == prompt_length: | ||
| assert False, "unreachable" |
There was a problem hiding this comment.
I'd put a better error message in case it actually happens
Narsil
previously approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.