feat: improve star coder to support multi lora layers #2883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
danieldk
previously approved these changes
Jan 9, 2025
Narsil
previously approved these changes
Jan 15, 2025
drbh
force-pushed
the
startcoder-support-multi-lora
branch
from
6d14cc3 to
d611f0f
Compare
|
optimistically merging since this PR was already approved and the only failing test appears to be flakey and unrelated. will watch for regressions and rollback if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
TensorParallelMultiAdapterLinearandTensorParallelAdapterRowLineartoflash_starcoder2_modeling.pyto enable multi lora with the starcoder2 model