Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc build] Use secrets #1273

Merged
merged 1 commit into from
Jun 9, 2023
Merged

[doc build] Use secrets #1273

merged 1 commit into from
Jun 9, 2023

Conversation

mishig25
Copy link
Contributor

@mishig25 mishig25 commented Jun 9, 2023

Companion pr to huggingface/doc-builder#379
Please feel free to merge it yourself

@mishig25 mishig25 requested a review from Narsil June 9, 2023 08:17
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure we want to have a doc builded for every PR cc @Narsil ?

Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Narsil
Copy link
Collaborator

Narsil commented Jun 9, 2023

Not entirely sure we want to have a doc builded for every PR cc @Narsil ?

It's already the case currently :)

@Narsil Narsil merged commit 348ed70 into main Jun 9, 2023
@Narsil Narsil deleted the docbuild-secrets branch June 9, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants