-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow huggingface_hub<1.0
#1385
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright with me 😉 Let's just wait for @Narsil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
asked by theBloke
too
Oh thank god! 😁
Thank you! |
@ArthurZucker Atm, transformers depends on |
@clefourrier this PR has been merged this morning to unpin |
Missed it, ty! |
I'll do a patch today to support this version as well 😉 |
Follow-up PR after #1383 and especially #1383 (comment). I still believe that we should not block
huggingface_hub
from introducing breaking changes. However for the most used and less prone to change APIs (like the upload/download ones), I'm more than fine to consider them as "fixed until at least v1.0".I've looked into
tokenizers
implementation and given that it uses onlyhf_hub_download
, let's sethuggingface_hub<1.0
as dependency. This will reduce the friction for users wanting to install the latesthuggingface_hub
version. If at any pointtokenizers
starts to use other methods, let's reassess and chose a solution described in #1383 (comment). In the meantime, I think we should merge this PR.(also related: once merged and released you should be able to delete #1377 @clefourrier)