-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove enforcement of non special when adding tokens #1521
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Not sure if we should mark it as breaking chnage (it is technically, although we're more respectful of user intent which could categorize as bugfix)
we'll do a "breaking" release soon anyways! More a bug fix IMO! |
Fix the issue that prevented us from adding special and non special tokens using a single call to
add_tokens
.Very important because calling this multiple times adds a huge slowdown (regex re-compilation).
before it would output
'<me-and-you>'
. and the token was always special when added.This will allow us to do the following cleanup: https://github.com/huggingface/transformers/blob/main/src/transformers/tokenization_utils_fast.py#L169-L192
this issue comes from c02d4e2 which was introduced in v0.8