Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: usage of node12 which is deprecated in CI #1659

Closed
wants to merge 2 commits into from
Closed

fix: usage of node12 which is deprecated in CI #1659

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25092bc
fix: usage of `node12 which is deprecated` in CI
hamirmahal Oct 17, 2024
3e7f99b
fix: failing `Node / Check everything builds` job
hamirmahal Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/docs-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,13 @@ jobs:
uses: actions/checkout@v3

- name: Install Python
uses: actions/setup-python@v1
uses: actions/setup-python@v5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v5 is the latest major version of actions/setup-python at the time of this writing.

with:
python-version: 3.9

- name: Install dependencies
run: pip install sphinx sphinx_rtd_theme setuptools-rust

- name: Install Rust
uses: actions-rs/toolchain@v1
with:
toolchain: stable
Comment on lines -24 to -27
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason why this one is deleted as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that action also uses node12 which is deprecated.


- name: Build tokenizers
working-directory: ./bindings/python
run: pip install -e .
Expand Down
Loading