-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Encoding mappings for pairs of sequence #506
Conversation
45923c7
to
bb7029d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The choice I would really think needs to be changed it the variant return type, it's really messy for users I think. I gave an example of something which I feel would both keep backcompat and be cleaner for users.
set_sequence_id
being exposed feels odd to me, I think we should probably add a realistic test where this might be used in production to convey why it's there (because destroying sequence sources being irreversible, we need a good reason to expose that IMO). Otherwise we should remove it until a convincing scenario is presented I feel.
c0e5f70
to
579044d
Compare
579044d
to
6e75098
Compare
Fix #486
Improve the mappings
XX_to_XX
methods by adding support for pairs of sequence:token_to_XX
methods now return a tuple with the sequence index and the expected result for pairs of sequencechar_to_XX
andword_to_XX
now accept a new argumentsequence_index
to specify the target input sequencetoken_to_sequence
method that can tell for any token, the associated input sequence.