Upgrade pyo3 to 0.15 #650
Upgrade pyo3 to 0.15 #650
Conversation
| @@ -29,9 +29,3 @@ tempfile = "3.1" | |||
|
|
|||
| [features] | |||
| default = ["pyo3/extension-module"] | |||
|
|
|||
| [target.x86_64-apple-darwin] | |||
There was a problem hiding this comment.
This is simply wrong place to put this.
warning: unused manifest key: target.x86_64-apple-darwin.rustflags
|
Thank you very much for your help with this @messense! I didn't have much time lately but I plan to move forward with this next week probably. |
| pyo3 = "0.12" | ||
| numpy = "0.12" | ||
| pyo3 = "0.15.0" | ||
| numpy = "0.15.0" |
There was a problem hiding this comment.
numpy does not need to move in sync with pyo3; there also does not exist a numpy 0.15...
There was a problem hiding this comment.
It needs to. And it's rust-numpy.
There was a problem hiding this comment.
OK, makes sense, thanks.
|
I'm no long interested in pushing this forward given the lack of review for a year now. Feel free to take over. |
Sorry to hear. I ran into needing this while packaging tokenizers for conda-forge (py3.10 builds fail in cross-compilation without pyo3 0.15) |
|
@messense @h-vetinari Sorry it took so long to review, @n1t0 is hard at work at HF, and simply stopped having time maintaining I am spending some time to maintain it because I love the library (and rust). Feel free to ping regularly if this ever happens again, GH notifications are sometimes not working too well (or dismissed by error). Thanks @h-vetinari for taking this over ! Cheers ! |
|
If @messense is not too demotivated to take this to completion, this would surely go faster than I'd ever pull it off as a pretty complete newbie. No expectation, but just saying. 😅 |
This would require dropping Python 3.5 support.