Expand documentation of UnigramTrainer #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sgugger I think we should update The |
|
Oh I didn't know that, added the same there. |
Narsil
reviewed
Aug 9, 2021
bindings/python/src/trainers.rs
Outdated
| /// | ||
| /// n_sub_iterations (:obj:`int`): | ||
| /// The number of iterations of the EM algorithm to perform before | ||
| /// pruning the vocabulary. | ||
| #[pyclass(extends=PyTrainer, module = "tokenizers.trainers", name=UnigramTrainer)] | ||
| #[text_signature = "(self, vocab_size=8000, show_progress=True, special_tokens= [])"] |
There was a problem hiding this comment.
I think this needs editing too. (There should be a test to detect that, let's see if it kicks in correctly.)
|
I had not seen this PR from @SaulLu. I think this PR is more comprehensive as it adds all the arguments the |
|
#773 (The rust version update) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the documentation of the UnigramTrainer does not contain all the options you can set, and the auto-complete in an IDE does not show them either.
This PR fixes that.