Fix windows err with checkpoint race conditions (#28637)

Fix windows err
huggingface · May 14, 2024 · 7636f1d · 7636f1d
1 parent c4bdb6d
commit 7636f1d
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/transformers/trainer.py b/src/transformers/trainer.py
@@ -2415,9 +2415,11 @@ def _save_checkpoint(self, model, trial, metrics=None):
                     os.rename(staging_output_dir, output_dir)
 
                     # Ensure rename completed in cases where os.rename is not atomic
-                    fd = os.open(output_dir, os.O_RDONLY)
-                    os.fsync(fd)
-                    os.close(fd)
+                    # And can only happen on non-windows based systems
+                    if os.name != "nt":
+                        fd = os.open(output_dir, os.O_RDONLY)
+                        os.fsync(fd)
+                        os.close(fd)
 
             # Maybe delete some older checkpoints.
             if self.args.should_save: