Skip to content

Commit

Permalink
Fix expected value in tests of the test fetcher (#24077)
Browse files Browse the repository at this point in the history
* Fix expected value in tests of the test fetcher

* Fix trigger for repo util tests
  • Loading branch information
sgugger authored Jun 7, 2023
1 parent 5c9394b commit 89b00ee
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 5 deletions.
13 changes: 10 additions & 3 deletions tests/repo_utils/test_tests_fetcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -526,10 +526,17 @@ def test_init_test_examples_dependencies(self):
create_tmp_repo(tmp_folder)

expected_example_deps = {
"examples/flax/test_flax_examples.py": ["examples/flax/text-classification/run_glue.py"],
"examples/pytorch/test_pytorch_examples.py": ["examples/pytorch/text-classification/run_glue.py"],
"examples/flax/test_flax_examples.py": [
"examples/flax/text-classification/run_glue.py",
"examples/flax/test_flax_examples.py",
],
"examples/pytorch/test_pytorch_examples.py": [
"examples/pytorch/text-classification/run_glue.py",
"examples/pytorch/test_pytorch_examples.py",
],
"examples/tensorflow/test_tensorflow_examples.py": [
"examples/tensorflow/text-classification/run_glue.py"
"examples/tensorflow/text-classification/run_glue.py",
"examples/tensorflow/test_tensorflow_examples.py",
],
}

Expand Down
8 changes: 6 additions & 2 deletions utils/tests_fetcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,9 @@ def extract_imports(module_fname, cache=None):
content = f.read()

# Filter out all docstrings to not get imports in code examples.
splits = content.split('"""')
# fmt: off
splits = content.split('\"\"\"')
# fmt: on
content = "".join(splits[::2])

module_parts = str(module_fname).split(os.path.sep)
Expand Down Expand Up @@ -694,12 +696,14 @@ def infer_tests_to_run(output_file, diff_with_last_commit=False, filter_models=T
if f in test_map:
test_files_to_run.extend(test_map[f])
test_files_to_run = sorted(set(test_files_to_run))
# Remove repo utils tests
test_files_to_run = [f for f in test_files_to_run if not f.split(os.path.sep)[1] == "repo_utils"]
# Remove SageMaker tests
test_files_to_run = [f for f in test_files_to_run if not f.split(os.path.sep)[1] == "sagemaker"]
# Make sure we did not end up with a test file that was removed
test_files_to_run = [f for f in test_files_to_run if (PATH_TO_REPO / f).exists()]

repo_utils_launch = any(f.split(os.path.sep)[1] == "repo_utils" for f in modified_files)
repo_utils_launch = any(f.split(os.path.sep)[0] == "utils" for f in modified_files)

if repo_utils_launch:
repo_util_file = Path(output_file).parent / "test_repo_utils.txt"
Expand Down

0 comments on commit 89b00ee

Please sign in to comment.