Removed "with open" due to not working with directory. os.open seems …

…to work for directories.
huggingface · Jan 9, 2024 · eb58698 · eb58698
1 parent df9f6e9
commit eb58698
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/transformers/trainer.py b/src/transformers/trainer.py
@@ -2390,9 +2390,9 @@ def _save_checkpoint(self, model, trial, metrics=None):
                     os.rename(staging_output_dir, output_dir)
 
                     # Ensure rename completed in cases where os.rename is not atomic
-                    with open(output_dir, "r") as f:
-                        f.flush()
-                        os.fsync(f.fileno())
+                    fd = os.open(output_dir, os.O_RDONLY)
+                    os.fsync(fd)
+                    os.close(fd)
 
             # Maybe delete some older checkpoints.
             if self.args.should_save: