Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] broken link in torchscript.mdx #23062

Closed
sim-so opened this issue Apr 29, 2023 · 2 comments · Fixed by #23060
Closed

[docs] broken link in torchscript.mdx #23062

sim-so opened this issue Apr 29, 2023 · 2 comments · Fixed by #23060

Comments

@sim-so
Copy link
Contributor

sim-so commented Apr 29, 2023

Description

Broken serialization#using-torchscript-in-python should be torchscript#using-torchscript-in-python, in line number 201 of torchscript.mdx.

Document / language

torchscript.mdx / en, kr

Suggestion

As is:

### Converting a model for AWS Neuron

Convert a model for AWS NEURON using the same code from [Using TorchScript in
Python](serialization#using-torchscript-in-python) to trace a `BertModel`. Import the
`torch.neuron` framework extension to access the components of the Neuron SDK through a
Python API:

To be:

### Converting a model for AWS Neuron

Convert a model for AWS NEURON using the same code from [Using TorchScript in
Python](torchscript#using-torchscript-in-python) to trace a `BertModel`. Import the
`torch.neuron` framework extension to access the components of the Neuron SDK through a
Python API:

Please let me know if I missed something in guideilnes.
Thank you in advance for your attention to it!

@stevhliu
Copy link
Member

stevhliu commented May 1, 2023

Thanks for catching this! Would you like to open a PR with your fix? 🤗

@sim-so
Copy link
Contributor Author

sim-so commented May 2, 2023

Hello, @stevhliu !
I opened PR #23060 for translating the document to Korean as well as fixing the issue.
Please let me know if it would be better to open another PR for the fix separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants