Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated torchscript.mdx to Korean #23060

Merged
merged 6 commits into from
May 2, 2023

Conversation

sim-so
Copy link
Contributor

@sim-so sim-so commented Apr 29, 2023

What does this PR do?

Translated the torchscript.mdx file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179
Fixes #23062

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team PseudoLab, may you please review this PR? @0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@sgugger, @ArthurZucker, @eunseojo
May you please review this PR?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 29, 2023

The documentation is not available anymore as the PR was closed or merged.

AWS가 클라우드에서 저비용, 고성능 머신 러닝 추론을 위한 [Amazon EC2 Inf1](https://aws.amazon.com/ec2/instance-types/inf1/) 인스턴스 제품군을 출시했습니다.
Inf1 인스턴스는 딥러닝 추론 워크로드에 특화된 맞춤 하드웨어 가속기인 AWS Inferentia 칩으로 구동됩니다.
[AWS Neuron](https://awsdocs-neuron.readthedocs-hosted.com/en/latest/#)은 Inferentia를 위한 SDK로, Inf1에 배포하기 위한 transformer 모델 추적 및 최적화를 지원합니다.
Neuron SDK는 다음과 같은 기능을 제공합니다:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inf1. 이 약자로 Neuron SDK와 함께 기술되어야 하는 지 확인 부탁드립니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWS 문서를 보면 인스턴스 이름으로 Inf1을 쓰고 있으며, Neuron SDK에 대한 설명이 함께 기술되어 있습니다. 혹시 문장에 어색한 점이 있을까요?

Copy link
Contributor

@0525hhgus 0525hhgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the good translation 😄 You even translated the new term carefully!
I leave reviews below.

docs/source/en/torchscript.mdx Show resolved Hide resolved
docs/source/ko/torchscript.mdx Outdated Show resolved Hide resolved
docs/source/ko/torchscript.mdx Outdated Show resolved Hide resolved
Co-authored-by: Hyeonseo Yun <0525yhs@gmail.com>
docs/source/ko/torchscript.mdx Outdated Show resolved Hide resolved
@sim-so
Copy link
Contributor Author

sim-so commented May 2, 2023

Could you review this PR? 😃
@sgugger, @ArthurZucker, @eunseojo

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@sgugger sgugger marked this pull request as ready for review May 2, 2023 13:27
@sgugger sgugger merged commit f31a510 into huggingface:main May 2, 2023
qywu pushed a commit to qywu/transformers that referenced this pull request May 3, 2023
* docs: ko: torchscript.mdx

* feat: gpt and deepl draft

* fix: manual edits

* fix: edit anchor link

* fix: resolve suggestions

Co-authored-by: Hyeonseo Yun <0525yhs@gmail.com>

* fix: resolve suggestions

---------

Co-authored-by: Hyeonseo Yun <0525yhs@gmail.com>
@sim-so sim-so deleted the ko-torchscript branch May 28, 2023 00:16
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
* docs: ko: torchscript.mdx

* feat: gpt and deepl draft

* fix: manual edits

* fix: edit anchor link

* fix: resolve suggestions

Co-authored-by: Hyeonseo Yun <0525yhs@gmail.com>

* fix: resolve suggestions

---------

Co-authored-by: Hyeonseo Yun <0525yhs@gmail.com>
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
* docs: ko: torchscript.mdx

* feat: gpt and deepl draft

* fix: manual edits

* fix: edit anchor link

* fix: resolve suggestions

Co-authored-by: Hyeonseo Yun <0525yhs@gmail.com>

* fix: resolve suggestions

---------

Co-authored-by: Hyeonseo Yun <0525yhs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] broken link in torchscript.mdx
6 participants