Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

self.pad_token detect should be is None rather than "not self.pad_token" #25625

Closed
aohan237 opened this issue Aug 21, 2023 · 2 comments · Fixed by #25685
Closed

self.pad_token detect should be is None rather than "not self.pad_token" #25625

aohan237 opened this issue Aug 21, 2023 · 2 comments · Fixed by #25685

Comments

@aohan237
Copy link

https://github.com/huggingface/transformers/blob/2f8acfea1ca11fe3479fb379ccbded516d0cff57/src/transformers/tokenization_utils_base.py#L2506C71-L2506C71
@ydshieh
Copy link
Collaborator

ydshieh commented Aug 23, 2023

Thanks! I agree.

@ArthurZucker If you agree, I can open a PR to update this tiny place.

@ArthurZucker
Copy link
Collaborator

Sure!

@ydshieh ydshieh mentioned this issue Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pad_token check condition huggingface/transformers
3 participants
@ydshieh @aohan237 @ArthurZucker