Fix pad_token check condition
#25685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Aug 23, 2023
| @@ -2503,7 +2503,7 @@ def _get_padding_truncation_strategies( | |||
| max_length = self.model_max_length | |||
|
|
|||
| # Test if we have a padding token | |||
| if padding_strategy != PaddingStrategy.DO_NOT_PAD and (not self.pad_token or self.pad_token_id < 0): | |||
There was a problem hiding this comment.
This line exist for 3 years but we don't have problem. Guess it's because we never has pad_token=0 (not id)
There was a problem hiding this comment.
Or rather ('n', 'no', 'f', 'false', 'off', '0') 🤣
ArthurZucker
approved these changes
Aug 23, 2023
| @@ -2503,7 +2503,7 @@ def _get_padding_truncation_strategies( | |||
| max_length = self.model_max_length | |||
|
|
|||
| # Test if we have a padding token | |||
| if padding_strategy != PaddingStrategy.DO_NOT_PAD and (not self.pad_token or self.pad_token_id < 0): | |||
There was a problem hiding this comment.
Or rather ('n', 'no', 'f', 'false', 'off', '0') 🤣
|
The documentation is not available anymore as the PR was closed or merged. |
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
fix Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
fix Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
fix Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix #25625