Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_mlm example is missing block_size and torch_dtype args (present in run_clm) #29697

Closed
2 of 4 tasks
galtay opened this issue Mar 17, 2024 · 2 comments · Fixed by #29776
Closed
2 of 4 tasks

run_mlm example is missing block_size and torch_dtype args (present in run_clm) #29697

galtay opened this issue Mar 17, 2024 · 2 comments · Fixed by #29776
Labels
Examples Which is related to examples in general Feature request Request for a new feature Good First Issue

Comments

@galtay
Copy link

galtay commented Mar 17, 2024

System Info

  • transformers version: 4.39.0.dev0
  • Platform: Linux-6.5.0-25-generic-x86_64-with-glibc2.35
  • Python version: 3.11.8
  • Huggingface_hub version: 0.21.4
  • Safetensors version: 0.4.2
  • Accelerate version: 0.28.0
  • Accelerate config: not found
  • PyTorch version (GPU?): 2.2.1+cu121 (True)
  • Tensorflow version (GPU?): not installed (NA)
  • Flax version (CPU?/GPU?/TPU?): not installed (NA)
  • Jax version: not installed
  • JaxLib version: not installed
  • Using GPU in script?: no
  • Using distributed or parallel set-up in script?: no

Who can help?

@ArthurZucker and @younesbelkada

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)

Reproduction

inspection of args in https://github.com/huggingface/transformers/blob/main/examples/pytorch/language-modeling/run_mlm.py
vs args in https://github.com/huggingface/transformers/blob/main/examples/pytorch/language-modeling/run_clm.py

Expected behavior

the ability to use torch_dtype and block_size args in the run_mlm.py script as they are used in the run_clm.py script.

@amyeroberts amyeroberts added the Feature request Request for a new feature label Mar 18, 2024
@amyeroberts
Copy link
Collaborator

Hi @galtay, thanks for opening this feature request!

Would you like to open a PR to add these?

@amyeroberts amyeroberts added Good First Issue Examples Which is related to examples in general labels Mar 18, 2024
@galtay
Copy link
Author

galtay commented Mar 18, 2024

thanks @amyeroberts agree this is more a feature request than a bug ;) will send a PR if I get the time ... was also thinking to try and update the examples so you can run with pre-tokenized data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Examples Which is related to examples in general Feature request Request for a new feature Good First Issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants