Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for torch_dtype in the run_mlm example #29776

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

jla524
Copy link
Contributor

@jla524 jla524 commented Mar 21, 2024

What does this PR do?

Fixes #29697 (issue)

  • match the torch_dtype argument in run_clm
  • max_seq_length is very similar to block_size and is left unchanged

Who can review?

@galtay and @amyeroberts

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@amyeroberts amyeroberts merged commit ef6e371 into huggingface:main Mar 21, 2024
7 checks passed
@jla524 jla524 deleted the run_mlm_dtype branch April 22, 2024 22:13
itazap pushed a commit that referenced this pull request May 14, 2024
feat: add support for torch_dtype

Co-authored-by: Jacky Lee <jackylee328@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run_mlm example is missing block_size and torch_dtype args (present in run_clm)
3 participants