Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix naming in TF MobileBERT #10095

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Fix naming in TF MobileBERT #10095

merged 1 commit into from
Feb 9, 2021

Conversation

jplu
Copy link
Contributor

@jplu jplu commented Feb 9, 2021

What does this PR do?

This PR fixes a naming issue in the TFMobileBertForMaskedLM model.

Fixes

#10088

@jplu jplu requested a review from LysandreJik February 9, 2021 10:41
LysandreJik
LysandreJik approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM! Thanks for taking care of it @jplu

@LysandreJik LysandreJik merged commit c6d5e56 into huggingface:master Feb 9, 2021
@jplu jplu deleted the fix-tf-mobilebert branch February 9, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jplu @LysandreJik