Fix TFConvBertModelIntegrationTest::test_inference_masked_lm Test #10104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekkrthakur
requested review from
jplu,
LysandreJik,
sgugger and
patrickvonplaten
jplu
approved these changes
Feb 9, 2021
|
@abhishekkrthakur - this doesn't look good to me. Just changing the hardcoded integration test to values that make the test pass does not seem like the way to go here. The PyTorch integration test: transformers/tests/test_modeling_convbert.py Line 430 in 7c7962b Also, it would be great if we could not merge PRs that have no description and that neither @sgugger, @LysandreJik or I approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.